call to populate surf_diff for implicit coupling#71
Open
JosephMouallem wants to merge 3 commits intoNOAA-GFDL:mainfrom
Open
call to populate surf_diff for implicit coupling#71JosephMouallem wants to merge 3 commits intoNOAA-GFDL:mainfrom
JosephMouallem wants to merge 3 commits intoNOAA-GFDL:mainfrom
Conversation
JosephMouallem
requested review from
laurenchilutti,
thomas-robinson and
uramirez8707
as code owners
Contributor
|
So if I understand, this set of PRs is to follow the logic of AMx and to encapsulate the required data types and movement within the appropriate components:
I see that |
Contributor
Author
|
This is true for the most part. |
gaokun227
reviewed
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
surf_diffis moved to the physics to be consistent with the AMx logic.Call to populate
surf_diffvariables after the downward sweep.Depends on:
NOAA-GFDL/GFDL_atmos_cubed_sphere#408
NOAA-GFDL/SHiELD_physics#83